Compare commits

...

2 Commits

Author SHA1 Message Date
djalim 9b021de765 style: fix deno fmt and lint
Check Deno code / Check Deno code (pull_request) Failing after 7s
Tests / Unit tests (pull_request) Successful in 11s
Tests / Integration tests (pull_request) Successful in 54s
2026-04-26 14:18:55 +02:00
djalim 30486d7b48 test(roles): add unit, integration and e2e tests for /roles (#112)
- unit: fixture shapes, mock API (GET/POST/PUT/DELETE), mock DB CRUD
- integration: list, create, assign permissions, update, reset perms, delete
- e2e: handler calls with mock context + real DB, covers 400/404 cases
2026-04-26 14:13:56 +02:00
4 changed files with 460 additions and 1 deletions
+3 -1
View File
@@ -2,7 +2,9 @@ import { defineConfig } from "drizzle-kit";
import process from "node:process";
const url = process.env.DATABASE_URL ??
`postgresql://${process.env.POSTGRES_USER}:${process.env.POSTGRES_PASS}@${process.env.POSTGRES_HOST ?? "localhost"}:${process.env.POSTGRES_PORT ?? 5432}/${process.env.POSTGRES_DB}`;
`postgresql://${process.env.POSTGRES_USER}:${process.env.POSTGRES_PASS}@${
process.env.POSTGRES_HOST ?? "localhost"
}:${process.env.POSTGRES_PORT ?? 5432}/${process.env.POSTGRES_DB}`;
export default defineConfig({
dialect: "postgresql",
+175
View File
@@ -0,0 +1,175 @@
// #112 - E2E tests for /roles endpoints
import { assertEquals, assertExists } from "@std/assert";
import {
makeEmployeeContext,
makeGetRequest,
makeJsonRequest,
} from "../helpers/handler.ts";
import { seedRoles, testDb, truncateAll } from "../helpers/db_integration.ts";
import { permissions } from "$root/databases/schema.ts";
import { handler as rolesHandler } from "$apps/admin/api/roles.ts";
import { handler as roleHandler } from "$apps/admin/api/roles/[idRole].ts";
// --- GET /roles ---
Deno.test({
name: "e2e roles: GET /roles returns all with permissions",
async fn() {
await truncateAll();
await seedRoles([{ nom: "admin" }, { nom: "employee" }]);
const res = await rolesHandler.GET!(
makeGetRequest("/roles"),
makeEmployeeContext(),
);
assertEquals(res.status, 200);
const body = await res.json();
assertEquals(body.length, 2);
assertExists(body[0].permissions);
assertEquals(Array.isArray(body[0].permissions), true);
},
sanitizeResources: false,
sanitizeOps: false,
});
// --- POST /roles ---
Deno.test({
name: "e2e roles: POST /roles creates role (201)",
async fn() {
await truncateAll();
const res = await rolesHandler.POST!(
makeJsonRequest("/roles", "POST", { nom: "viewer" }),
makeEmployeeContext(),
);
assertEquals(res.status, 201);
const body = await res.json();
assertExists(body.id);
assertEquals(body.nom, "viewer");
assertEquals(body.permissions, []);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "e2e roles: POST /roles 400 on missing nom",
async fn() {
await truncateAll();
const res = await rolesHandler.POST!(
makeJsonRequest("/roles", "POST", {}),
makeEmployeeContext(),
);
assertEquals(res.status, 400);
},
sanitizeResources: false,
sanitizeOps: false,
});
// --- GET /roles/:id ---
Deno.test({
name: "e2e roles: GET /roles/:id returns role with permissions",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "admin" }]);
await testDb.insert(permissions).values([
{ id: "student_read", nom: "Consulter les élèves" },
]);
const res = await roleHandler.GET!(
makeGetRequest(`/roles/${role.id}`),
makeEmployeeContext({ idRole: String(role.id) }),
);
assertEquals(res.status, 200);
const body = await res.json();
assertEquals(body.nom, "admin");
assertEquals(Array.isArray(body.permissions), true);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "e2e roles: GET /roles/:id 404 when not found",
async fn() {
await truncateAll();
const res = await roleHandler.GET!(
makeGetRequest("/roles/9999"),
makeEmployeeContext({ idRole: "9999" }),
);
assertEquals(res.status, 404);
},
sanitizeResources: false,
sanitizeOps: false,
});
// --- PUT /roles/:id ---
Deno.test({
name: "e2e roles: PUT /roles/:id updates nom and permissions",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "employee" }]);
await testDb.insert(permissions).values([
{ id: "note_read", nom: "Consulter les notes" },
]);
const res = await roleHandler.PUT!(
makeJsonRequest(`/roles/${role.id}`, "PUT", {
nom: "teacher",
permissions: ["note_read"],
}),
makeEmployeeContext({ idRole: String(role.id) }),
);
assertEquals(res.status, 200);
const body = await res.json();
assertEquals(body.nom, "teacher");
assertEquals(body.permissions, ["note_read"]);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "e2e roles: PUT /roles/:id 404 when not found",
async fn() {
await truncateAll();
const res = await roleHandler.PUT!(
makeJsonRequest("/roles/9999", "PUT", { nom: "ghost", permissions: [] }),
makeEmployeeContext({ idRole: "9999" }),
);
assertEquals(res.status, 404);
},
sanitizeResources: false,
sanitizeOps: false,
});
// --- DELETE /roles/:id ---
Deno.test({
name: "e2e roles: DELETE /roles/:id returns 204",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "moderator" }]);
const res = await roleHandler.DELETE!(
makeGetRequest(`/roles/${role.id}`),
makeEmployeeContext({ idRole: String(role.id) }),
);
assertEquals(res.status, 204);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "e2e roles: DELETE /roles/:id 404 when not found",
async fn() {
await truncateAll();
const res = await roleHandler.DELETE!(
makeGetRequest("/roles/9999"),
makeEmployeeContext({ idRole: "9999" }),
);
assertEquals(res.status, 404);
},
sanitizeResources: false,
sanitizeOps: false,
});
+123
View File
@@ -0,0 +1,123 @@
// #112 - Integration tests for /roles endpoints
import { assertEquals, assertExists } from "@std/assert";
import { seedRoles, testDb, truncateAll } from "../helpers/db_integration.ts";
import { permissions, rolePermissions, roles } from "$root/databases/schema.ts";
import { eq } from "npm:drizzle-orm@0.45.2";
Deno.test({
name: "integration roles: list all roles",
async fn() {
await truncateAll();
await seedRoles([{ nom: "admin" }, { nom: "employee" }]);
const rows = await testDb.select().from(roles);
assertEquals(rows.length, 2);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "integration roles: create and retrieve by id",
async fn() {
await truncateAll();
const [created] = await testDb.insert(roles).values({ nom: "viewer" })
.returning();
assertExists(created.id);
assertEquals(created.nom, "viewer");
const row = await testDb
.select()
.from(roles)
.where(eq(roles.id, created.id))
.then((r) => r[0] ?? null);
assertExists(row);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "integration roles: assign and retrieve permissions",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "admin" }]);
await testDb.insert(permissions).values([
{ id: "student_read", nom: "Consulter les élèves" },
{ id: "student_write", nom: "Gérer les élèves" },
]);
await testDb.insert(rolePermissions).values([
{ idRole: role.id, idPermission: "student_read" },
{ idRole: role.id, idPermission: "student_write" },
]);
const perms = await testDb
.select()
.from(rolePermissions)
.where(eq(rolePermissions.idRole, role.id));
assertEquals(perms.length, 2);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "integration roles: update role nom",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "employee" }]);
const [updated] = await testDb
.update(roles)
.set({ nom: "teacher" })
.where(eq(roles.id, role.id))
.returning();
assertEquals(updated.nom, "teacher");
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "integration roles: reset permissions on update",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "admin" }]);
await testDb.insert(permissions).values([
{ id: "note_read", nom: "Consulter les notes" },
{ id: "note_write", nom: "Gérer les notes" },
]);
await testDb.insert(rolePermissions).values([
{ idRole: role.id, idPermission: "note_read" },
]);
// reset
await testDb.delete(rolePermissions).where(
eq(rolePermissions.idRole, role.id),
);
await testDb.insert(rolePermissions).values([
{ idRole: role.id, idPermission: "note_write" },
]);
const perms = await testDb
.select()
.from(rolePermissions)
.where(eq(rolePermissions.idRole, role.id));
assertEquals(perms.length, 1);
assertEquals(perms[0].idPermission, "note_write");
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "integration roles: delete role removes it",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "moderator" }]);
await testDb.delete(roles).where(eq(roles.id, role.id));
const row = await testDb
.select()
.from(roles)
.where(eq(roles.id, role.id))
.then((r) => r[0] ?? null);
assertEquals(row, null);
},
sanitizeResources: false,
sanitizeOps: false,
});
+159
View File
@@ -0,0 +1,159 @@
// #112 - Unit tests for /roles endpoints
import { assertEquals, assertExists } from "@std/assert";
import { mockFetch, restoreFetch } from "../helpers/api_mock.ts";
import { createMockDb } from "../helpers/db_mock.ts";
interface Role {
id: number;
nom: string;
permissions: string[];
}
const roles: Role[] = [
{ id: 1, nom: "admin", permissions: ["student_read", "student_write"] },
{ id: 2, nom: "employee", permissions: ["student_read"] },
];
// --- Fixtures ---
Deno.test("roles: fixtures have correct shape", () => {
assertEquals(roles.length, 2);
assertEquals(typeof roles[0].id, "number");
assertEquals(typeof roles[0].nom, "string");
assertEquals(Array.isArray(roles[0].permissions), true);
});
Deno.test("roles: permissions are strings", () => {
assertEquals(roles[0].permissions.every((p) => typeof p === "string"), true);
});
// --- Mock API ---
Deno.test("mock API: GET /roles returns list with permissions", async () => {
mockFetch({ "/roles": roles });
try {
const res = await fetch("http://localhost/api/roles");
assertEquals(res.status, 200);
const data: Role[] = await res.json();
assertEquals(data.length, 2);
assertExists(data.find((r) => r.nom === "admin"));
assertEquals(data[0].permissions.length, 2);
} finally {
restoreFetch();
}
});
Deno.test("mock API: GET /roles/:id returns role", async () => {
mockFetch({ "/roles/1": roles[0] });
try {
const res = await fetch("http://localhost/api/roles/1");
assertEquals(res.status, 200);
const data: Role = await res.json();
assertEquals(data.nom, "admin");
assertEquals(data.permissions.length, 2);
} finally {
restoreFetch();
}
});
Deno.test("mock API: GET /roles/:id 404 when not found", async () => {
mockFetch({
"/roles/99": { status: 404, body: { error: "Ressource introuvable" } },
});
try {
const res = await fetch("http://localhost/api/roles/99");
assertEquals(res.status, 404);
} finally {
restoreFetch();
}
});
Deno.test("mock API: POST /roles creates role (201)", async () => {
const newRole: Role = { id: 3, nom: "viewer", permissions: [] };
mockFetch({ "/roles": { method: "POST", status: 201, body: newRole } });
try {
const res = await fetch("http://localhost/api/roles", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({ nom: "viewer" }),
});
assertEquals(res.status, 201);
const data: Role = await res.json();
assertEquals(data.nom, "viewer");
assertEquals(data.permissions.length, 0);
} finally {
restoreFetch();
}
});
Deno.test("mock API: POST /roles 400 on missing nom", async () => {
mockFetch({ "/roles": { method: "POST", status: 400 } });
try {
const res = await fetch("http://localhost/api/roles", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({}),
});
assertEquals(res.status, 400);
} finally {
restoreFetch();
}
});
Deno.test("mock API: PUT /roles/:id updates role and permissions", async () => {
const updated: Role = { id: 2, nom: "teacher", permissions: ["note_read"] };
mockFetch({ "/roles/2": { method: "PUT", status: 200, body: updated } });
try {
const res = await fetch("http://localhost/api/roles/2", {
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify({ nom: "teacher", permissions: ["note_read"] }),
});
assertEquals(res.status, 200);
const data: Role = await res.json();
assertEquals(data.nom, "teacher");
assertEquals(data.permissions, ["note_read"]);
} finally {
restoreFetch();
}
});
Deno.test("mock API: DELETE /roles/:id returns 204", async () => {
mockFetch({ "/roles/2": { method: "DELETE", status: 204 } });
try {
const res = await fetch("http://localhost/api/roles/2", {
method: "DELETE",
});
assertEquals(res.status, 204);
} finally {
restoreFetch();
}
});
// --- Mock DB ---
Deno.test("mock DB: find role by id", () => {
const db = createMockDb({ tables: { roles: [...roles] } });
const r = db.findOne<Role>("roles", (r) => r.id === 1);
assertExists(r);
assertEquals(r.nom, "admin");
});
Deno.test("mock DB: insert role", () => {
const db = createMockDb({ tables: { roles: [...roles] } });
db.insert<Role>("roles", { id: 3, nom: "viewer", permissions: [] });
assertEquals(db.getTable("roles").length, 3);
});
Deno.test("mock DB: update role nom", () => {
const db = createMockDb({ tables: { roles: [...roles] } });
db.updateWhere<Role>("roles", (r) => r.id === 2, { nom: "teacher" });
assertEquals(db.findOne<Role>("roles", (r) => r.id === 2)?.nom, "teacher");
});
Deno.test("mock DB: delete role", () => {
const db = createMockDb({ tables: { roles: [...roles] } });
db.deleteWhere<Role>("roles", (r) => r.id === 1);
assertEquals(db.getTable("roles").length, 1);
});