Compare commits

...

5 Commits

Author SHA1 Message Date
djalim 2d1b8b65b9 Revert "ci: remove Run tests step from lint workflow"
Check Deno code / Check Deno code (pull_request) Failing after 7s
Tests / Unit tests (pull_request) Successful in 12s
Tests / Integration tests (pull_request) Successful in 56s
This reverts commit a1782527a6.
2026-04-26 14:53:25 +02:00
djalim a1782527a6 ci: remove Run tests step from lint workflow
Check Deno code / Check Deno code (pull_request) Failing after 5s
Tests / Unit tests (pull_request) Successful in 11s
Tests / Integration tests (pull_request) Successful in 54s
2026-04-26 14:24:55 +02:00
djalim 204cce4227 fix: remove unused body variable in permissions e2e test
Check Deno code / Check Deno code (pull_request) Failing after 9s
Tests / Unit tests (pull_request) Successful in 10s
Tests / Integration tests (pull_request) Successful in 56s
2026-04-26 14:19:26 +02:00
djalim f5497536f0 style: fix deno fmt and lint 2026-04-26 14:18:55 +02:00
djalim b0cf5aed6f test(permissions): add unit and e2e tests for GET /permissions (#115)
Handler is static (no DB), tests verify the 9 known permissions are returned
with correct id/nom shapes.
2026-04-26 14:14:04 +02:00
3 changed files with 110 additions and 1 deletions
+3 -1
View File
@@ -2,7 +2,9 @@ import { defineConfig } from "drizzle-kit";
import process from "node:process";
const url = process.env.DATABASE_URL ??
`postgresql://${process.env.POSTGRES_USER}:${process.env.POSTGRES_PASS}@${process.env.POSTGRES_HOST ?? "localhost"}:${process.env.POSTGRES_PORT ?? 5432}/${process.env.POSTGRES_DB}`;
`postgresql://${process.env.POSTGRES_USER}:${process.env.POSTGRES_PASS}@${
process.env.POSTGRES_HOST ?? "localhost"
}:${process.env.POSTGRES_PORT ?? 5432}/${process.env.POSTGRES_DB}`;
export default defineConfig({
dialect: "postgresql",
+42
View File
@@ -0,0 +1,42 @@
// #115 - E2E tests for GET /permissions
// Handler statique (pas de DB), test direct du handler
import { assertEquals, assertExists } from "@std/assert";
import { makeEmployeeContext, makeGetRequest } from "../helpers/handler.ts";
import { handler as permissionsHandler } from "$apps/admin/api/permissions.ts";
Deno.test({
name: "e2e permissions: GET /permissions returns all 9 permissions",
fn() {
const res = permissionsHandler.GET!(
makeGetRequest("/permissions"),
makeEmployeeContext(),
);
assertEquals(res.status, 200);
return res.text().then((text) => {
const data = JSON.parse(text);
assertEquals(data.length, 9);
assertExists(data.find((p: { id: string }) => p.id === "student_read"));
assertExists(data.find((p: { id: string }) => p.id === "role_write"));
});
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "e2e permissions: GET /permissions - all entries have id and nom",
async fn() {
const res = permissionsHandler.GET!(
makeGetRequest("/permissions"),
makeEmployeeContext(),
);
const data: { id: string; nom: string }[] = await res.json();
for (const p of data) {
assertEquals(typeof p.id, "string");
assertEquals(typeof p.nom, "string");
}
},
sanitizeResources: false,
sanitizeOps: false,
});
+65
View File
@@ -0,0 +1,65 @@
// #115 - Unit tests for GET /permissions
import { assertEquals, assertExists } from "@std/assert";
import { mockFetch, restoreFetch } from "../helpers/api_mock.ts";
interface Permission {
id: string;
nom: string;
}
const EXPECTED_PERMISSIONS: Permission[] = [
{ id: "student_read", nom: "Consulter les élèves" },
{ id: "student_write", nom: "Gérer les élèves" },
{ id: "note_read", nom: "Consulter les notes" },
{ id: "note_write", nom: "Gérer les notes" },
{ id: "module_read", nom: "Consulter les modules" },
{ id: "module_write", nom: "Gérer les modules" },
{ id: "user_read", nom: "Consulter les utilisateurs" },
{ id: "user_write", nom: "Gérer les utilisateurs" },
{ id: "role_write", nom: "Gérer les rôles" },
];
Deno.test("permissions: known permission ids", () => {
const ids = EXPECTED_PERMISSIONS.map((p) => p.id);
assertEquals(ids.includes("student_read"), true);
assertEquals(ids.includes("student_write"), true);
assertEquals(ids.includes("note_read"), true);
assertEquals(ids.includes("role_write"), true);
assertEquals(ids.length, 9);
});
Deno.test("permissions: all permissions have string id and nom", () => {
for (const p of EXPECTED_PERMISSIONS) {
assertEquals(typeof p.id, "string");
assertEquals(typeof p.nom, "string");
}
});
Deno.test("mock API: GET /permissions returns all permissions", async () => {
mockFetch({ "/permissions": EXPECTED_PERMISSIONS });
try {
const res = await fetch("http://localhost/api/permissions");
assertEquals(res.status, 200);
const data: Permission[] = await res.json();
assertEquals(data.length, 9);
assertExists(data.find((p) => p.id === "student_read"));
assertExists(data.find((p) => p.id === "role_write"));
} finally {
restoreFetch();
}
});
Deno.test("mock API: GET /permissions - each permission has id and nom", async () => {
mockFetch({ "/permissions": EXPECTED_PERMISSIONS });
try {
const res = await fetch("http://localhost/api/permissions");
const data: Permission[] = await res.json();
for (const p of data) {
assertExists(p.id);
assertExists(p.nom);
}
} finally {
restoreFetch();
}
});