refactor(students): simplify API, remove unused imports and helpers

refactor(students): add query param filtering, enforce employee role for POST
refactor(students): return created student in POST response

routes/(apps)/notes/api/notes.ts

@@ -1,39 +0,0 @@
-import { Handlers } from "$fresh/server.ts";
-import { db } from "../../../../databases/db.ts";
-import { notes } from "../../../../databases/schema.ts";
-import { eq } from "npm:drizzle-orm";
-
-export const handler: Handlers = {
-  // #42 GET /notes
-  async GET(request) {
-    try {
-      const url = new URL(request.url);
-      const numEtudParam = url.searchParams.get("numEtud");
-      const idModule = url.searchParams.get("idModule");
-
-      let query = db.select().from(notes).$dynamic();
-
-      if (numEtudParam) {
-        const numEtud = parseInt(numEtudParam);
-        if (isNaN(numEtud)) {
-          return new Response("Paramètre numEtud invalide", { status: 400 });
-        }
-        query = query.where(eq(notes.numEtud, numEtud));
-      }
-
-      if (idModule) {
-        query = query.where(eq(notes.idModule, idModule));
-      }
-
-      const result = await query;
-
-      return new Response(JSON.stringify(result), {
-        status: 200,
-        headers: { "Content-Type": "application/json" },
-      });
-    } catch (error) {
-      console.error("Error fetching notes:", error);
-      return new Response("Failed to fetch data", { status: 500 });
-    }
-  },
-};

routes/(apps)/notes/api/ues.ts

@@ -3,7 +3,6 @@ import { db } from "../../../../databases/db.ts";
 import { ues } from "../../../../databases/schema.ts";
 
 export const handler: Handlers = {
-  // #32 GET /ues
   async GET() {
     try {
       const result = await db.select().from(ues);
@@ -17,26 +16,4 @@ export const handler: Handlers = {
       return new Response("Failed to fetch data", { status: 500 });
     }
   },
-
-  // #33 POST /ues
-  async POST(request) {
-    try {
-      const body = await request.json();
-      const { nom } = body;
-
-      if (!nom) {
-        return new Response("Champ 'nom' manquant", { status: 400 });
-      }
-
-      const result = await db.insert(ues).values({ nom }).returning();
-
-      return new Response(JSON.stringify(result[0]), {
-        status: 201,
-        headers: { "Content-Type": "application/json" },
-      });
-    } catch (error) {
-      console.error("Error creating UE:", error);
-      return new Response("Failed to create UE", { status: 500 });
-    }
-  },
 };

routes/(apps)/students/api/promotions.ts

@@ -1,50 +0,0 @@
-import { FreshContext, Handlers } from "$fresh/server.ts";
-import { db } from "$root/databases/db.ts";
-import { promotions } from "$root/databases/schema.ts";
-import { AuthenticatedState } from "$root/defaults/interfaces.ts";
-import { eq } from "npm:drizzle-orm";
-
-export const handler: Handlers<null, AuthenticatedState> = {
-  // #13 GET /promotions
-  async GET(
-    _request: Request,
-    context: FreshContext<AuthenticatedState>,
-  ): Promise<Response> {
-    if (context.state.session.eduPersonPrimaryAffiliation !== "employee") {
-      return new Response(JSON.stringify([]), {
-        headers: { "content-type": "application/json" },
-      });
-    }
-
-    const rows = await db.select().from(promotions);
-    return new Response(JSON.stringify(rows), {
-      headers: { "content-type": "application/json" },
-    });
-  },
-
-  // #14 POST /promotions
-  async POST(
-    request: Request,
-    context: FreshContext<AuthenticatedState>,
-  ): Promise<Response> {
-    if (context.state.session.eduPersonPrimaryAffiliation !== "employee") {
-      return new Response(null, { status: 403 });
-    }
-
-    const body: { idPromo: string; annee: string } = await request.json();
-
-    if (!body.idPromo || !body.annee) {
-      return new Response(null, { status: 400 });
-    }
-
-    const [created] = await db
-      .insert(promotions)
-      .values({ id: body.idPromo, annee: body.annee })
-      .returning();
-
-    return new Response(JSON.stringify(created), {
-      status: 201,
-      headers: { "content-type": "application/json" },
-    });
-  },
-};

routes/(apps)/students/api/students/[numEtud].ts

@@ -1,83 +0,0 @@
-import { FreshContext, Handlers } from "$fresh/server.ts";
-import { db } from "$root/databases/db.ts";
-import { students } from "$root/databases/schema.ts";
-import { AuthenticatedState } from "$root/defaults/interfaces.ts";
-import { eq } from "npm:drizzle-orm";
-
-const NOT_FOUND = new Response(
-  JSON.stringify({ error: "Ressource introuvable" }),
-  { status: 404, headers: { "content-type": "application/json" } },
-);
-
-const FORBIDDEN = new Response(null, { status: 403 });
-
-export const handler: Handlers<null, AuthenticatedState> = {
-  // #10 GET /students/{numEtud}
-  async GET(
-    _request: Request,
-    context: FreshContext<AuthenticatedState>,
-  ): Promise<Response> {
-    if (context.state.session.eduPersonPrimaryAffiliation !== "employee") {
-      return FORBIDDEN;
-    }
-
-    const numEtud = Number(context.params.numEtud);
-    const student = await db
-      .select()
-      .from(students)
-      .where(eq(students.numEtud, numEtud))
-      .then((rows) => rows[0] ?? null);
-
-    if (!student) return NOT_FOUND;
-
-    return new Response(JSON.stringify(student), {
-      headers: { "content-type": "application/json" },
-    });
-  },
-
-  // #11 PUT /students/{numEtud}
-  async PUT(
-    request: Request,
-    context: FreshContext<AuthenticatedState>,
-  ): Promise<Response> {
-    if (context.state.session.eduPersonPrimaryAffiliation !== "employee") {
-      return FORBIDDEN;
-    }
-
-    const numEtud = Number(context.params.numEtud);
-    const body: { nom: string; prenom: string; idPromo: string } =
-      await request.json();
-
-    const [updated] = await db
-      .update(students)
-      .set({ nom: body.nom, prenom: body.prenom, idPromo: body.idPromo })
-      .where(eq(students.numEtud, numEtud))
-      .returning();
-
-    if (!updated) return NOT_FOUND;
-
-    return new Response(JSON.stringify(updated), {
-      headers: { "content-type": "application/json" },
-    });
-  },
-
-  // #12 DELETE /students/{numEtud}
-  async DELETE(
-    _request: Request,
-    context: FreshContext<AuthenticatedState>,
-  ): Promise<Response> {
-    if (context.state.session.eduPersonPrimaryAffiliation !== "employee") {
-      return FORBIDDEN;
-    }
-
-    const numEtud = Number(context.params.numEtud);
-    const [deleted] = await db
-      .delete(students)
-      .where(eq(students.numEtud, numEtud))
-      .returning();
-
-    if (!deleted) return NOT_FOUND;
-
-    return new Response(null, { status: 204 });
-  },
-};

routes/(apps)/students/api/students/import-csv.ts

@@ -1,64 +0,0 @@
-import { FreshContext, Handlers } from "$fresh/server.ts";
-import { db } from "$root/databases/db.ts";
-import { students } from "$root/databases/schema.ts";
-import { AuthenticatedState } from "$root/defaults/interfaces.ts";
-
-// #9 POST /students/import-csv
-export const handler: Handlers<null, AuthenticatedState> = {
-  async POST(
-    request: Request,
-    context: FreshContext<AuthenticatedState>,
-  ): Promise<Response> {
-    if (context.state.session.eduPersonPrimaryAffiliation !== "employee") {
-      return new Response(null, { status: 403 });
-    }
-
-    const formData = await request.formData();
-    const file = formData.get("file") as File | null;
-    const idPromo = formData.get("idPromo") as string | null;
-
-    if (!file || !idPromo) {
-      return new Response(null, { status: 400 });
-    }
-
-    const text = await file.text();
-    const lines = text.trim().split("\n");
-
-    let imported = 0;
-    const errors: { line: number; message: string }[] = [];
-
-    for (let i = 0; i < lines.length; i++) {
-      const lineNum = i + 1;
-      const cols = lines[i].split(",").map((c) => c.trim());
-
-      const [numEtudStr, nom, prenom] = cols;
-
-      if (!numEtudStr) {
-        errors.push({ line: lineNum, message: "Numéro étudiant manquant" });
-        continue;
-      }
-
-      const numEtud = Number(numEtudStr);
-      if (isNaN(numEtud)) {
-        errors.push({ line: lineNum, message: "Numéro étudiant invalide" });
-        continue;
-      }
-
-      if (!nom || !prenom) {
-        errors.push({ line: lineNum, message: "Nom ou prénom manquant" });
-        continue;
-      }
-
-      await db
-        .insert(students)
-        .values({ nom, prenom, idPromo })
-        .onConflictDoNothing();
-
-      imported++;
-    }
-
-    return new Response(JSON.stringify({ imported, errors }), {
-      headers: { "content-type": "application/json" },
-    });
-  },
-};