Compare commits

...

3 Commits

Author SHA1 Message Date
djalim c283a34784 🔧 ci: add Deno lint and format check workflow
Check Deno code / Check Deno code (pull_request) Successful in 5s
2026-01-09 12:47:36 +01:00
djalim cd1149a23a Merge pull request '🐛(components): add missing button types and keys' (#3) from fix/actions into main
Reviewed-on: https://git.polytech.djalim.fr/admin/PolyMPR/pulls/3
2026-01-09 11:44:17 +00:00
djalim 58c8ff56ba 🐛(components): add missing button types and keys
Check Deno code / Check Deno code (pull_request) Successful in 40s
Add type="button" to the EditMobility and UploadStudents buttons
to prevent default form submission behavior.
Include a key prop on Student components in Promotion for stable list rendering.
2026-01-09 12:41:51 +01:00
4 changed files with 29 additions and 3 deletions
+26
View File
@@ -0,0 +1,26 @@
name: "Check Deno code"
on:
pull_request:
branches:
- main
permissions:
contents: read
jobs:
check-code:
name: "Check Deno code"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: denoland/setup-deno@v2
with:
deno-version: v2.x
- name: Check formatting
run: deno fmt --check
- name: Check linting
run: deno lint
@@ -240,7 +240,7 @@ export default function EditMobility() {
</table>
</div>
))}
<button onClick={handleSave} disabled={isSaving}>
<button type="button" onClick={handleSave} disabled={isSaving}>
{isSaving ? "Saving..." : "Confirm"}
</button>
</section>
@@ -22,7 +22,7 @@ export default function Promotion(props: PromotionProps) {
<tbody>
{props.students
.filter((student) => student.promotionId === props.promo.id)
.map((student) => <Student student={student} />)}
.map((student) => <Student key={student.id} student={student} />)}
</tbody>
</table>
</div>
@@ -104,7 +104,7 @@ export default function UploadStudents() {
return (
<>
<input type="file" accept=".xlsx, .xls" onChange={handleFileChange} />
<button onClick={confirmUpload}>Confirm Upload</button>
<button type="button" onClick={confirmUpload}>Confirm Upload</button>
<p>{statusMessage.value}</p>
</>
);