Compare commits

..

16 Commits

Author SHA1 Message Date
djalim 07b6f1e347 chore(test-framework): remove endpoint-specific tests from framework branch
Tests / Unit tests (pull_request) Successful in 12s
Tests / Integration tests (pull_request) Failing after 54s
Each endpoint's tests will be on their own issue branch (PMPR-109, etc.).
The framework branch only contains: CI config, db helpers, migrations.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-26 13:55:21 +02:00
djalim c5018d9ced test(integration): add DB integration tests for students, promotions, roles, modules
Covers full CRUD for each resource via testDb:
- promotions: list, create, get by id, not found, update, delete
- students: list, filter by promo, create, get, not found, update, delete
- roles: list, create, get with permissions, update+reset perms, delete
- modules: list, create, duplicate id rejection, get, not found, update, delete

27 integration tests passing in CI (act + Gitea Actions).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-26 13:37:02 +02:00
djalim 367b0b2357 fix(ci): fix postgres TCP setup and truncateAll superuser error
Tests / Unit tests (pull_request) Successful in 12s
Tests / Integration tests (pull_request) Successful in 58s
- Use apt-get install + configure listen_addresses + md5 auth in pg_hba
  so psql can connect via 127.0.0.1 (not just Unix socket)
- Use pg_ctlcluster restart after config changes + wait for pg_isready
- Replace session_replication_role (requires superuser) with a single
  TRUNCATE ... CASCADE which handles FK deps without elevated privileges
- All 3 integration tests now pass in CI (act + Gitea Actions)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2026-04-26 13:22:45 +02:00
djalim e0ac451372 fix(ci): use connection URL with ssl:false in drizzle config
Tests / Unit tests (pull_request) Successful in 13s
Tests / Integration tests (pull_request) Failing after 56s
2026-04-26 00:57:38 +02:00
djalim ae5d5b64ac debug(ci): add connection diagnostics before migrate
Tests / Unit tests (pull_request) Successful in 11s
Tests / Integration tests (pull_request) Failing after 56s
2026-04-26 00:54:11 +02:00
djalim 7be13737d5 fix(ci): remove unsupported --verbose from drizzle-kit migrate
Tests / Unit tests (pull_request) Successful in 11s
Tests / Integration tests (pull_request) Failing after 53s
2026-04-26 00:51:22 +02:00
djalim 32052ab1c9 fix(ci): add GRANT on public schema and verbose migrate output
Tests / Unit tests (pull_request) Successful in 11s
Tests / Integration tests (pull_request) Failing after 54s
2026-04-26 00:48:57 +02:00
djalim ce807391c6 fix(ci): start postgres with pg_ctlcluster instead of systemctl
Tests / Unit tests (pull_request) Successful in 11s
Tests / Integration tests (pull_request) Failing after 53s
2026-04-26 00:46:02 +02:00
djalim 182342aab0 fix(ci): install postgres via apt-get instead of docker
Tests / Unit tests (pull_request) Successful in 11s
Tests / Integration tests (pull_request) Failing after 25s
2026-04-26 00:43:11 +02:00
djalim d32758b310 fix(ci): use docker run instead of services for postgres 2026-04-26 00:41:20 +02:00
djalim f26b2b044f fix(ci): use bash /dev/tcp for postgres readiness check
Tests / Unit tests (pull_request) Successful in 12s
Tests / Integration tests (pull_request) Has been cancelled
2026-04-26 00:37:21 +02:00
djalim af2562ef2b fix(ci): replace pg_isready with nc for postgres readiness check
Tests / Unit tests (pull_request) Successful in 11s
Tests / Integration tests (pull_request) Has been cancelled
2026-04-26 00:35:42 +02:00
djalim f739f94403 fix(ci): use deno install for unit tests, add postgres readiness check
Tests / Unit tests (pull_request) Successful in 13s
Tests / Integration tests (pull_request) Has been cancelled
2026-04-26 00:31:15 +02:00
djalim f66de20dad fix(ci): install npm deps before running unit tests
Tests / Unit tests (pull_request) Failing after 27s
Tests / Integration tests (pull_request) Failing after 27s
2026-04-26 00:27:07 +02:00
djalim ea61d83384 fix(lint): add version to drizzle-orm imports and prefix unused NOT_FOUND
Tests / Unit tests (pull_request) Failing after 6s
Tests / Integration tests (pull_request) Failing after 1m28s
2026-04-26 00:24:27 +02:00
djalim 6402f802e9 chore(test): set up integration test framework with postgres
- Generate Drizzle migrations (databases/migrations/)
- Add databases/schema.kit.ts for drizzle-kit (Node-compatible imports)
- Update drizzle.config.ts to use schema.kit.ts
- Add deno tasks: test:unit, test:integration, migrate
- Add tests/helpers/db_integration.ts: testDb, truncateAll, seed helpers
- Add .gitea/workflows/test.yml: CI with postgres service container
- Update lint.yml: run test:unit only (no DB needed)
- Update deploy.yml: add check-code job, gate deploy on it
2026-04-26 00:23:12 +02:00
7 changed files with 1 additions and 539 deletions
-17
View File
@@ -6,26 +6,9 @@ on:
- main
jobs:
check-code:
name: "Check Deno code"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: denoland/setup-deno@v2
with:
deno-version: v2.x
- name: Check formatting
run: deno fmt --check
- name: Check linting
run: deno lint
deploy:
name: "Build Docker image"
runs-on: ubuntu-latest
needs: check-code
steps:
- name: Login to Docker Hub
uses: docker/login-action@v3
-4
View File
@@ -4,10 +4,6 @@ on:
pull_request:
branches:
- main
- develop
push:
branches:
- develop
permissions:
contents: read
+1 -3
View File
@@ -2,9 +2,7 @@ import { defineConfig } from "drizzle-kit";
import process from "node:process";
const url = process.env.DATABASE_URL ??
`postgresql://${process.env.POSTGRES_USER}:${process.env.POSTGRES_PASS}@${
process.env.POSTGRES_HOST ?? "localhost"
}:${process.env.POSTGRES_PORT ?? 5432}/${process.env.POSTGRES_DB}`;
`postgresql://${process.env.POSTGRES_USER}:${process.env.POSTGRES_PASS}@${process.env.POSTGRES_HOST ?? "localhost"}:${process.env.POSTGRES_PORT ?? 5432}/${process.env.POSTGRES_DB}`;
export default defineConfig({
dialect: "postgresql",
-175
View File
@@ -1,175 +0,0 @@
// #112 - E2E tests for /roles endpoints
import { assertEquals, assertExists } from "@std/assert";
import {
makeEmployeeContext,
makeGetRequest,
makeJsonRequest,
} from "../helpers/handler.ts";
import { seedRoles, testDb, truncateAll } from "../helpers/db_integration.ts";
import { permissions } from "$root/databases/schema.ts";
import { handler as rolesHandler } from "$apps/admin/api/roles.ts";
import { handler as roleHandler } from "$apps/admin/api/roles/[idRole].ts";
// --- GET /roles ---
Deno.test({
name: "e2e roles: GET /roles returns all with permissions",
async fn() {
await truncateAll();
await seedRoles([{ nom: "admin" }, { nom: "employee" }]);
const res = await rolesHandler.GET!(
makeGetRequest("/roles"),
makeEmployeeContext(),
);
assertEquals(res.status, 200);
const body = await res.json();
assertEquals(body.length, 2);
assertExists(body[0].permissions);
assertEquals(Array.isArray(body[0].permissions), true);
},
sanitizeResources: false,
sanitizeOps: false,
});
// --- POST /roles ---
Deno.test({
name: "e2e roles: POST /roles creates role (201)",
async fn() {
await truncateAll();
const res = await rolesHandler.POST!(
makeJsonRequest("/roles", "POST", { nom: "viewer" }),
makeEmployeeContext(),
);
assertEquals(res.status, 201);
const body = await res.json();
assertExists(body.id);
assertEquals(body.nom, "viewer");
assertEquals(body.permissions, []);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "e2e roles: POST /roles 400 on missing nom",
async fn() {
await truncateAll();
const res = await rolesHandler.POST!(
makeJsonRequest("/roles", "POST", {}),
makeEmployeeContext(),
);
assertEquals(res.status, 400);
},
sanitizeResources: false,
sanitizeOps: false,
});
// --- GET /roles/:id ---
Deno.test({
name: "e2e roles: GET /roles/:id returns role with permissions",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "admin" }]);
await testDb.insert(permissions).values([
{ id: "student_read", nom: "Consulter les élèves" },
]);
const res = await roleHandler.GET!(
makeGetRequest(`/roles/${role.id}`),
makeEmployeeContext({ idRole: String(role.id) }),
);
assertEquals(res.status, 200);
const body = await res.json();
assertEquals(body.nom, "admin");
assertEquals(Array.isArray(body.permissions), true);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "e2e roles: GET /roles/:id 404 when not found",
async fn() {
await truncateAll();
const res = await roleHandler.GET!(
makeGetRequest("/roles/9999"),
makeEmployeeContext({ idRole: "9999" }),
);
assertEquals(res.status, 404);
},
sanitizeResources: false,
sanitizeOps: false,
});
// --- PUT /roles/:id ---
Deno.test({
name: "e2e roles: PUT /roles/:id updates nom and permissions",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "employee" }]);
await testDb.insert(permissions).values([
{ id: "note_read", nom: "Consulter les notes" },
]);
const res = await roleHandler.PUT!(
makeJsonRequest(`/roles/${role.id}`, "PUT", {
nom: "teacher",
permissions: ["note_read"],
}),
makeEmployeeContext({ idRole: String(role.id) }),
);
assertEquals(res.status, 200);
const body = await res.json();
assertEquals(body.nom, "teacher");
assertEquals(body.permissions, ["note_read"]);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "e2e roles: PUT /roles/:id 404 when not found",
async fn() {
await truncateAll();
const res = await roleHandler.PUT!(
makeJsonRequest("/roles/9999", "PUT", { nom: "ghost", permissions: [] }),
makeEmployeeContext({ idRole: "9999" }),
);
assertEquals(res.status, 404);
},
sanitizeResources: false,
sanitizeOps: false,
});
// --- DELETE /roles/:id ---
Deno.test({
name: "e2e roles: DELETE /roles/:id returns 204",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "moderator" }]);
const res = await roleHandler.DELETE!(
makeGetRequest(`/roles/${role.id}`),
makeEmployeeContext({ idRole: String(role.id) }),
);
assertEquals(res.status, 204);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "e2e roles: DELETE /roles/:id 404 when not found",
async fn() {
await truncateAll();
const res = await roleHandler.DELETE!(
makeGetRequest("/roles/9999"),
makeEmployeeContext({ idRole: "9999" }),
);
assertEquals(res.status, 404);
},
sanitizeResources: false,
sanitizeOps: false,
});
-123
View File
@@ -1,123 +0,0 @@
// #112 - Integration tests for /roles endpoints
import { assertEquals, assertExists } from "@std/assert";
import { seedRoles, testDb, truncateAll } from "../helpers/db_integration.ts";
import { permissions, rolePermissions, roles } from "$root/databases/schema.ts";
import { eq } from "npm:drizzle-orm@0.45.2";
Deno.test({
name: "integration roles: list all roles",
async fn() {
await truncateAll();
await seedRoles([{ nom: "admin" }, { nom: "employee" }]);
const rows = await testDb.select().from(roles);
assertEquals(rows.length, 2);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "integration roles: create and retrieve by id",
async fn() {
await truncateAll();
const [created] = await testDb.insert(roles).values({ nom: "viewer" })
.returning();
assertExists(created.id);
assertEquals(created.nom, "viewer");
const row = await testDb
.select()
.from(roles)
.where(eq(roles.id, created.id))
.then((r) => r[0] ?? null);
assertExists(row);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "integration roles: assign and retrieve permissions",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "admin" }]);
await testDb.insert(permissions).values([
{ id: "student_read", nom: "Consulter les élèves" },
{ id: "student_write", nom: "Gérer les élèves" },
]);
await testDb.insert(rolePermissions).values([
{ idRole: role.id, idPermission: "student_read" },
{ idRole: role.id, idPermission: "student_write" },
]);
const perms = await testDb
.select()
.from(rolePermissions)
.where(eq(rolePermissions.idRole, role.id));
assertEquals(perms.length, 2);
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "integration roles: update role nom",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "employee" }]);
const [updated] = await testDb
.update(roles)
.set({ nom: "teacher" })
.where(eq(roles.id, role.id))
.returning();
assertEquals(updated.nom, "teacher");
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "integration roles: reset permissions on update",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "admin" }]);
await testDb.insert(permissions).values([
{ id: "note_read", nom: "Consulter les notes" },
{ id: "note_write", nom: "Gérer les notes" },
]);
await testDb.insert(rolePermissions).values([
{ idRole: role.id, idPermission: "note_read" },
]);
// reset
await testDb.delete(rolePermissions).where(
eq(rolePermissions.idRole, role.id),
);
await testDb.insert(rolePermissions).values([
{ idRole: role.id, idPermission: "note_write" },
]);
const perms = await testDb
.select()
.from(rolePermissions)
.where(eq(rolePermissions.idRole, role.id));
assertEquals(perms.length, 1);
assertEquals(perms[0].idPermission, "note_write");
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "integration roles: delete role removes it",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "moderator" }]);
await testDb.delete(roles).where(eq(roles.id, role.id));
const row = await testDb
.select()
.from(roles)
.where(eq(roles.id, role.id))
.then((r) => r[0] ?? null);
assertEquals(row, null);
},
sanitizeResources: false,
sanitizeOps: false,
});
-58
View File
@@ -1,58 +0,0 @@
import { assertEquals, assertExists } from "@std/assert";
import {
closeTestPool,
seedRoles,
seedUsers,
testDb,
truncateAll,
} from "../helpers/db_integration.ts";
import { users } from "$root/databases/schema.ts";
Deno.test({
name: "integration: GET /users - DB round trip",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "employee" }]);
await seedUsers([
{ id: "dupont.jean", nom: "Dupont", prenom: "Jean", idRole: role.id },
{ id: "martin.alice", nom: "Martin", prenom: "Alice", idRole: role.id },
]);
const rows = await testDb.select().from(users);
assertEquals(rows.length, 2);
assertExists(rows.find((u) => u.id === "dupont.jean"));
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "integration: INSERT user and retrieve by id",
async fn() {
await truncateAll();
const [role] = await seedRoles([{ nom: "admin" }]);
const [created] = await testDb.insert(users).values({
id: "durand.claire",
nom: "Durand",
prenom: "Claire",
idRole: role.id,
}).returning();
assertExists(created);
assertEquals(created.id, "durand.claire");
assertEquals(created.nom, "Durand");
},
sanitizeResources: false,
sanitizeOps: false,
});
Deno.test({
name: "integration: cleanup - close pool",
async fn() {
await closeTestPool();
},
sanitizeResources: false,
sanitizeOps: false,
});
-159
View File
@@ -1,159 +0,0 @@
// #112 - Unit tests for /roles endpoints
import { assertEquals, assertExists } from "@std/assert";
import { mockFetch, restoreFetch } from "../helpers/api_mock.ts";
import { createMockDb } from "../helpers/db_mock.ts";
interface Role {
id: number;
nom: string;
permissions: string[];
}
const roles: Role[] = [
{ id: 1, nom: "admin", permissions: ["student_read", "student_write"] },
{ id: 2, nom: "employee", permissions: ["student_read"] },
];
// --- Fixtures ---
Deno.test("roles: fixtures have correct shape", () => {
assertEquals(roles.length, 2);
assertEquals(typeof roles[0].id, "number");
assertEquals(typeof roles[0].nom, "string");
assertEquals(Array.isArray(roles[0].permissions), true);
});
Deno.test("roles: permissions are strings", () => {
assertEquals(roles[0].permissions.every((p) => typeof p === "string"), true);
});
// --- Mock API ---
Deno.test("mock API: GET /roles returns list with permissions", async () => {
mockFetch({ "/roles": roles });
try {
const res = await fetch("http://localhost/api/roles");
assertEquals(res.status, 200);
const data: Role[] = await res.json();
assertEquals(data.length, 2);
assertExists(data.find((r) => r.nom === "admin"));
assertEquals(data[0].permissions.length, 2);
} finally {
restoreFetch();
}
});
Deno.test("mock API: GET /roles/:id returns role", async () => {
mockFetch({ "/roles/1": roles[0] });
try {
const res = await fetch("http://localhost/api/roles/1");
assertEquals(res.status, 200);
const data: Role = await res.json();
assertEquals(data.nom, "admin");
assertEquals(data.permissions.length, 2);
} finally {
restoreFetch();
}
});
Deno.test("mock API: GET /roles/:id 404 when not found", async () => {
mockFetch({
"/roles/99": { status: 404, body: { error: "Ressource introuvable" } },
});
try {
const res = await fetch("http://localhost/api/roles/99");
assertEquals(res.status, 404);
} finally {
restoreFetch();
}
});
Deno.test("mock API: POST /roles creates role (201)", async () => {
const newRole: Role = { id: 3, nom: "viewer", permissions: [] };
mockFetch({ "/roles": { method: "POST", status: 201, body: newRole } });
try {
const res = await fetch("http://localhost/api/roles", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({ nom: "viewer" }),
});
assertEquals(res.status, 201);
const data: Role = await res.json();
assertEquals(data.nom, "viewer");
assertEquals(data.permissions.length, 0);
} finally {
restoreFetch();
}
});
Deno.test("mock API: POST /roles 400 on missing nom", async () => {
mockFetch({ "/roles": { method: "POST", status: 400 } });
try {
const res = await fetch("http://localhost/api/roles", {
method: "POST",
headers: { "content-type": "application/json" },
body: JSON.stringify({}),
});
assertEquals(res.status, 400);
} finally {
restoreFetch();
}
});
Deno.test("mock API: PUT /roles/:id updates role and permissions", async () => {
const updated: Role = { id: 2, nom: "teacher", permissions: ["note_read"] };
mockFetch({ "/roles/2": { method: "PUT", status: 200, body: updated } });
try {
const res = await fetch("http://localhost/api/roles/2", {
method: "PUT",
headers: { "content-type": "application/json" },
body: JSON.stringify({ nom: "teacher", permissions: ["note_read"] }),
});
assertEquals(res.status, 200);
const data: Role = await res.json();
assertEquals(data.nom, "teacher");
assertEquals(data.permissions, ["note_read"]);
} finally {
restoreFetch();
}
});
Deno.test("mock API: DELETE /roles/:id returns 204", async () => {
mockFetch({ "/roles/2": { method: "DELETE", status: 204 } });
try {
const res = await fetch("http://localhost/api/roles/2", {
method: "DELETE",
});
assertEquals(res.status, 204);
} finally {
restoreFetch();
}
});
// --- Mock DB ---
Deno.test("mock DB: find role by id", () => {
const db = createMockDb({ tables: { roles: [...roles] } });
const r = db.findOne<Role>("roles", (r) => r.id === 1);
assertExists(r);
assertEquals(r.nom, "admin");
});
Deno.test("mock DB: insert role", () => {
const db = createMockDb({ tables: { roles: [...roles] } });
db.insert<Role>("roles", { id: 3, nom: "viewer", permissions: [] });
assertEquals(db.getTable("roles").length, 3);
});
Deno.test("mock DB: update role nom", () => {
const db = createMockDb({ tables: { roles: [...roles] } });
db.updateWhere<Role>("roles", (r) => r.id === 2, { nom: "teacher" });
assertEquals(db.findOne<Role>("roles", (r) => r.id === 2)?.nom, "teacher");
});
Deno.test("mock DB: delete role", () => {
const db = createMockDb({ tables: { roles: [...roles] } });
db.deleteWhere<Role>("roles", (r) => r.id === 1);
assertEquals(db.getTable("roles").length, 1);
});