Compare commits

...

2 Commits

Author SHA1 Message Date
djalim f959cf0d3a feat(students): add CSV import endpoint for student data 2026-04-22 14:10:18 +02:00
djalim 0d45bd4c1c refactor(students): simplify API, remove unused imports and helpers
refactor(students): add query param filtering, enforce employee role for POST
refactor(students): return created student in POST response
2026-04-22 14:06:01 +02:00
2 changed files with 99 additions and 100 deletions
+35 -100
View File
@@ -1,122 +1,57 @@
import { FreshContext, Handlers } from "$fresh/server.ts"; import { FreshContext, Handlers } from "$fresh/server.ts";
import { db } from "$root/databases/db.ts"; import { db } from "$root/databases/db.ts";
import { promotions, students } from "$root/databases/schema.ts"; import { students } from "$root/databases/schema.ts";
import { AuthenticatedState } from "$root/defaults/interfaces.ts"; import { AuthenticatedState } from "$root/defaults/interfaces.ts";
import { eq, lt } from "npm:drizzle-orm"; import { eq } from "npm:drizzle-orm";
async function getItself(
userId: string,
): Promise<{ student: Student | null; promo: Promotion | null }> {
const student = await db
.select()
.from(students)
.where(eq(students.userId, userId))
.limit(1)
.then((rows) => rows[0] ?? null);
if (!student) {
return { student: null, promo: null };
}
const promo = await db
.select()
.from(promotions)
.where(eq(promotions.id, student.promotionId!))
.limit(1)
.then((rows) => rows[0] ?? null);
return { student, promo };
}
async function getAll(): Promise<
{ students: Student[]; promos: Promotion[] }
> {
const rows = await db
.select({
userId: students.userId,
firstName: students.firstName,
lastName: students.lastName,
mail: students.mail,
promotionId: students.promotionId,
})
.from(students)
.innerJoin(promotions, eq(students.promotionId, promotions.id))
.where(lt(promotions.current, 6));
const promos = await db
.select()
.from(promotions)
.where(lt(promotions.current, 6));
return { students: rows as Student[], promos };
}
async function addStudents(
studentList: Student[],
promoId: number,
): Promise<void> {
for (const student of studentList) {
await db
.insert(students)
.values({
userId: student.userId,
firstName: student.firstName,
lastName: student.lastName,
mail: student.mail,
promotionId: promoId,
})
.onConflictDoNothing();
}
}
export const handler: Handlers<null, AuthenticatedState> = { export const handler: Handlers<null, AuthenticatedState> = {
// #7 GET /students
async GET( async GET(
_request: Request, request: Request,
context: FreshContext<AuthenticatedState>, context: FreshContext<AuthenticatedState>,
): Promise<Response> { ): Promise<Response> {
if (context.state.session.eduPersonPrimaryAffiliation == "student") { if (context.state.session.eduPersonPrimaryAffiliation !== "employee") {
return new Response( return new Response(JSON.stringify([]), {
JSON.stringify(await getItself(context.state.session.uid)), headers: { "content-type": "application/json" },
{ headers: { "content-type": "application/json" } }, });
);
} }
return new Response( const url = new URL(request.url);
JSON.stringify(await getAll()), const idPromo = url.searchParams.get("idPromo");
{ headers: { "content-type": "application/json" } },
); const rows = idPromo
? await db.select().from(students).where(eq(students.idPromo, idPromo))
: await db.select().from(students);
return new Response(JSON.stringify(rows), {
headers: { "content-type": "application/json" },
});
}, },
// #8 POST /students
async POST( async POST(
request: Request, request: Request,
_context: FreshContext<AuthenticatedState>, context: FreshContext<AuthenticatedState>,
): Promise<Response> { ): Promise<Response> {
const { students: studentList, promo }: { if (context.state.session.eduPersonPrimaryAffiliation !== "employee") {
students: Student[]; return new Response(null, { status: 403 });
promo: string; }
} = await request.json();
if (!promo || !promo.match(/^\d{4}-\dA$/) || !Array.isArray(studentList)) { const body: { numEtud: number; nom: string; prenom: string; idPromo: string } =
await request.json();
if (!body.nom || !body.prenom || !body.idPromo) {
return new Response(null, { status: 400 }); return new Response(null, { status: 400 });
} }
const { endyear, current } = promo.match( const [created] = await db
/^(?<endyear>\d{4})-(?<current>\d)A$/, .insert(students)
)?.groups!; .values({ nom: body.nom, prenom: body.prenom, idPromo: body.idPromo })
.returning();
await db return new Response(JSON.stringify(created), {
.insert(promotions) status: 201,
.values({ endyear: Number(endyear), current: Number(current) }) headers: { "content-type": "application/json" },
.onConflictDoNothing(); });
const promo_row = await db
.select()
.from(promotions)
.where(eq(promotions.endyear, Number(endyear)))
.then((rows) => rows.find((r) => r.current === Number(current))!);
await addStudents(studentList, promo_row.id);
return new Response(null, { status: 201 });
}, },
}; };
@@ -0,0 +1,64 @@
import { FreshContext, Handlers } from "$fresh/server.ts";
import { db } from "$root/databases/db.ts";
import { students } from "$root/databases/schema.ts";
import { AuthenticatedState } from "$root/defaults/interfaces.ts";
// #9 POST /students/import-csv
export const handler: Handlers<null, AuthenticatedState> = {
async POST(
request: Request,
context: FreshContext<AuthenticatedState>,
): Promise<Response> {
if (context.state.session.eduPersonPrimaryAffiliation !== "employee") {
return new Response(null, { status: 403 });
}
const formData = await request.formData();
const file = formData.get("file") as File | null;
const idPromo = formData.get("idPromo") as string | null;
if (!file || !idPromo) {
return new Response(null, { status: 400 });
}
const text = await file.text();
const lines = text.trim().split("\n");
let imported = 0;
const errors: { line: number; message: string }[] = [];
for (let i = 0; i < lines.length; i++) {
const lineNum = i + 1;
const cols = lines[i].split(",").map((c) => c.trim());
const [numEtudStr, nom, prenom] = cols;
if (!numEtudStr) {
errors.push({ line: lineNum, message: "Numéro étudiant manquant" });
continue;
}
const numEtud = Number(numEtudStr);
if (isNaN(numEtud)) {
errors.push({ line: lineNum, message: "Numéro étudiant invalide" });
continue;
}
if (!nom || !prenom) {
errors.push({ line: lineNum, message: "Nom ou prénom manquant" });
continue;
}
await db
.insert(students)
.values({ nom, prenom, idPromo })
.onConflictDoNothing();
imported++;
}
return new Response(JSON.stringify({ imported, errors }), {
headers: { "content-type": "application/json" },
});
},
};