chore(test-framework): remove endpoint-specific tests from framework branch

Each endpoint's tests will be on their own issue branch (PMPR-109, etc.). The framework branch only contains: CI config, db helpers, migrations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
test(integration): add DB integration tests for students, promotions, roles, modules
2026-04-26 13:55:21 +02:00 · 2026-04-26 13:37:02 +02:00 · 2026-04-26 13:22:45 +02:00 · 2026-04-26 00:57:38 +02:00 · 2026-04-26 00:54:11 +02:00 · 2026-04-26 00:51:22 +02:00
6 changed files with 1 additions and 628 deletions
@@ -6,26 +6,9 @@ on:
      - main
 jobs:
  check-code:
    name: "Check Deno code"
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v4
      - uses: denoland/setup-deno@v2
        with:
          deno-version: v2.x
      - name: Check formatting
        run: deno fmt --check
      - name: Check linting
        run: deno lint
  deploy:
    name: "Build Docker image"
    runs-on: ubuntu-latest
    needs: check-code
    steps:
      - name: Login to Docker Hub
        uses: docker/login-action@v3
@@ -4,10 +4,6 @@ on:
  pull_request:
    branches:
      - main
      - develop
  push:
    branches:
      - develop
 permissions:
  contents: read
@@ -2,9 +2,7 @@ import { defineConfig } from "drizzle-kit";
 import process from "node:process";
 const url = process.env.DATABASE_URL ??
-  `postgresql://${process.env.POSTGRES_USER}:${process.env.POSTGRES_PASS}@${
+  `postgresql://${process.env.POSTGRES_USER}:${process.env.POSTGRES_PASS}@${process.env.POSTGRES_HOST ?? "localhost"}:${process.env.POSTGRES_PORT ?? 5432}/${process.env.POSTGRES_DB}`;
    process.env.POSTGRES_HOST ?? "localhost"
  }:${process.env.POSTGRES_PORT ?? 5432}/${process.env.POSTGRES_DB}`;
 export default defineConfig({
  dialect: "postgresql",
@@ -1,250 +0,0 @@
 // #111 - E2E tests for /users endpoints
 import { assertEquals, assertExists } from "@std/assert";
 import {
  makeEmployeeContext,
  makeGetRequest,
  makeJsonRequest,
 } from "../helpers/handler.ts";
 import {
  seedRoles,
  seedUsers,
  truncateAll,
 } from "../helpers/db_integration.ts";
 import { handler as usersHandler } from "$apps/admin/api/users.ts";
 import { handler as userHandler } from "$apps/admin/api/users/[id].ts";
 // --- GET /users ---
 Deno.test({
  name: "e2e users: GET /users returns all users",
  async fn() {
    await truncateAll();
    const [role] = await seedRoles([{ nom: "employee" }]);
    await seedUsers([
      { id: "dupont.jean", nom: "Dupont", prenom: "Jean", idRole: role.id },
      { id: "martin.alice", nom: "Martin", prenom: "Alice", idRole: role.id },
    ]);
    const res = await usersHandler.GET!(
      makeGetRequest("/users"),
      makeEmployeeContext(),
    );
    assertEquals(res.status, 200);
    const body = await res.json();
    assertEquals(body.length, 2);
    assertExists(body.find((u: { id: string }) => u.id === "dupont.jean"));
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 Deno.test({
  name: "e2e users: GET /users?idRole filters by role",
  async fn() {
    await truncateAll();
    const [role1] = await seedRoles([{ nom: "admin" }]);
    const [role2] = await seedRoles([{ nom: "employee" }]);
    await seedUsers([
      { id: "u1", nom: "A", prenom: "A", idRole: role1.id },
      { id: "u2", nom: "B", prenom: "B", idRole: role2.id },
    ]);
    const res = await usersHandler.GET!(
      makeGetRequest("/users", { idRole: String(role1.id) }),
      makeEmployeeContext(),
    );
    assertEquals(res.status, 200);
    const body = await res.json();
    assertEquals(body.length, 1);
    assertEquals(body[0].id, "u1");
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 // --- POST /users ---
 Deno.test({
  name: "e2e users: POST /users creates user (201)",
  async fn() {
    await truncateAll();
    const [role] = await seedRoles([{ nom: "employee" }]);
    const res = await usersHandler.POST!(
      makeJsonRequest("/users", "POST", {
        id: "nouveau.user",
        nom: "Nouveau",
        prenom: "User",
        idRole: role.id,
      }),
      makeEmployeeContext(),
    );
    assertEquals(res.status, 201);
    const body = await res.json();
    assertEquals(body.id, "nouveau.user");
    assertExists(body.nom);
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 Deno.test({
  name: "e2e users: POST /users 409 on duplicate id",
  async fn() {
    await truncateAll();
    const [role] = await seedRoles([{ nom: "employee" }]);
    await seedUsers([{
      id: "dup.user",
      nom: "A",
      prenom: "A",
      idRole: role.id,
    }]);
    const res = await usersHandler.POST!(
      makeJsonRequest("/users", "POST", {
        id: "dup.user",
        nom: "B",
        prenom: "B",
        idRole: role.id,
      }),
      makeEmployeeContext(),
    );
    assertEquals(res.status, 409);
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 Deno.test({
  name: "e2e users: POST /users 400 on missing fields",
  async fn() {
    await truncateAll();
    const res = await usersHandler.POST!(
      makeJsonRequest("/users", "POST", { id: "x" }),
      makeEmployeeContext(),
    );
    assertEquals(res.status, 400);
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 // --- GET /users/:id ---
 Deno.test({
  name: "e2e users: GET /users/:id returns user",
  async fn() {
    await truncateAll();
    const [role] = await seedRoles([{ nom: "employee" }]);
    await seedUsers([{
      id: "test.user",
      nom: "Test",
      prenom: "User",
      idRole: role.id,
    }]);
    const res = await userHandler.GET!(
      makeGetRequest("/users/test.user"),
      makeEmployeeContext({ id: "test.user" }),
    );
    assertEquals(res.status, 200);
    const body = await res.json();
    assertEquals(body.id, "test.user");
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 Deno.test({
  name: "e2e users: GET /users/:id 404 when not found",
  async fn() {
    await truncateAll();
    const res = await userHandler.GET!(
      makeGetRequest("/users/ghost"),
      makeEmployeeContext({ id: "ghost" }),
    );
    assertEquals(res.status, 404);
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 // --- PUT /users/:id ---
 Deno.test({
  name: "e2e users: PUT /users/:id updates user",
  async fn() {
    await truncateAll();
    const [role] = await seedRoles([{ nom: "employee" }]);
    await seedUsers([{
      id: "upd.user",
      nom: "Old",
      prenom: "Name",
      idRole: role.id,
    }]);
    const res = await userHandler.PUT!(
      makeJsonRequest("/users/upd.user", "PUT", {
        nom: "New",
        prenom: "Name",
        idRole: role.id,
      }),
      makeEmployeeContext({ id: "upd.user" }),
    );
    assertEquals(res.status, 200);
    const body = await res.json();
    assertEquals(body.nom, "New");
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 Deno.test({
  name: "e2e users: PUT /users/:id 404 when not found",
  async fn() {
    await truncateAll();
    const res = await userHandler.PUT!(
      makeJsonRequest("/users/ghost", "PUT", {
        nom: "X",
        prenom: "Y",
        idRole: 1,
      }),
      makeEmployeeContext({ id: "ghost" }),
    );
    assertEquals(res.status, 404);
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 // --- DELETE /users/:id ---
 Deno.test({
  name: "e2e users: DELETE /users/:id returns 204",
  async fn() {
    await truncateAll();
    const [role] = await seedRoles([{ nom: "employee" }]);
    await seedUsers([{
      id: "del.user",
      nom: "Del",
      prenom: "Me",
      idRole: role.id,
    }]);
    const res = await userHandler.DELETE!(
      makeGetRequest("/users/del.user"),
      makeEmployeeContext({ id: "del.user" }),
    );
    assertEquals(res.status, 204);
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 Deno.test({
  name: "e2e users: DELETE /users/:id 404 when not found",
  async fn() {
    await truncateAll();
    const res = await userHandler.DELETE!(
      makeGetRequest("/users/ghost"),
      makeEmployeeContext({ id: "ghost" }),
    );
    assertEquals(res.status, 404);
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
@@ -1,138 +0,0 @@
 // #111 - Integration tests for /users endpoints
 import { assertEquals, assertExists } from "@std/assert";
 import {
  seedRoles,
  seedUsers,
  testDb,
  truncateAll,
 } from "../helpers/db_integration.ts";
 import { users } from "$root/databases/schema.ts";
 import { eq } from "npm:drizzle-orm@0.45.2";
 Deno.test({
  name: "integration users: list all users",
  async fn() {
    await truncateAll();
    const [role] = await seedRoles([{ nom: "employee" }]);
    await seedUsers([
      { id: "dupont.jean", nom: "Dupont", prenom: "Jean", idRole: role.id },
      { id: "martin.alice", nom: "Martin", prenom: "Alice", idRole: role.id },
    ]);
    const rows = await testDb.select().from(users);
    assertEquals(rows.length, 2);
    assertExists(rows.find((u) => u.id === "dupont.jean"));
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 Deno.test({
  name: "integration users: filter by idRole",
  async fn() {
    await truncateAll();
    const [role1] = await seedRoles([{ nom: "admin" }]);
    const [role2] = await seedRoles([{ nom: "employee" }]);
    await seedUsers([
      { id: "u1", nom: "A", prenom: "A", idRole: role1.id },
      { id: "u2", nom: "B", prenom: "B", idRole: role2.id },
    ]);
    const rows = await testDb
      .select()
      .from(users)
      .where(eq(users.idRole, role1.id));
    assertEquals(rows.length, 1);
    assertEquals(rows[0].id, "u1");
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 Deno.test({
  name: "integration users: create and retrieve by id",
  async fn() {
    await truncateAll();
    const [role] = await seedRoles([{ nom: "admin" }]);
    const [created] = await testDb
      .insert(users)
      .values({
        id: "durand.claire",
        nom: "Durand",
        prenom: "Claire",
        idRole: role.id,
      })
      .returning();
    assertExists(created);
    assertEquals(created.id, "durand.claire");
    const row = await testDb
      .select()
      .from(users)
      .where(eq(users.id, "durand.claire"))
      .then((r) => r[0] ?? null);
    assertExists(row);
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 Deno.test({
  name: "integration users: get by id returns null when not found",
  async fn() {
    await truncateAll();
    const row = await testDb
      .select()
      .from(users)
      .where(eq(users.id, "nonexistent"))
      .then((r) => r[0] ?? null);
    assertEquals(row, null);
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 Deno.test({
  name: "integration users: update user fields",
  async fn() {
    await truncateAll();
    const [role] = await seedRoles([{ nom: "employee" }]);
    await seedUsers([{
      id: "test.user",
      nom: "Test",
      prenom: "User",
      idRole: role.id,
    }]);
    const [updated] = await testDb
      .update(users)
      .set({ nom: "Updated", prenom: "Name" })
      .where(eq(users.id, "test.user"))
      .returning();
    assertExists(updated);
    assertEquals(updated.nom, "Updated");
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
 Deno.test({
  name: "integration users: delete user",
  async fn() {
    await truncateAll();
    const [role] = await seedRoles([{ nom: "employee" }]);
    await seedUsers([{
      id: "to.delete",
      nom: "Del",
      prenom: "Me",
      idRole: role.id,
    }]);
    await testDb.delete(users).where(eq(users.id, "to.delete"));
    const row = await testDb
      .select()
      .from(users)
      .where(eq(users.id, "to.delete"))
      .then((r) => r[0] ?? null);
    assertEquals(row, null);
  },
  sanitizeResources: false,
  sanitizeOps: false,
 });
@@ -1,216 +0,0 @@
 import { assertEquals } from "@std/assert";
 import { getFetchCalls, mockFetch, restoreFetch } from "../helpers/api_mock.ts";
 const BASE = "http://localhost/apps/admin/api/users";
 const users = [
  { id: "dupont.jean", nom: "Dupont", prenom: "Jean", idRole: 1 },
  { id: "martin.alice", nom: "Martin", prenom: "Alice", idRole: 2 },
 ];
 // --- GET /users ---
 Deno.test("GET /users - returns all users", async () => {
  mockFetch({ [BASE]: users });
  try {
    const res = await fetch(BASE);
    assertEquals(res.status, 200);
    const data = await res.json();
    assertEquals(data.length, 2);
    assertEquals(data[0].id, "dupont.jean");
  } finally {
    restoreFetch();
  }
 });
 Deno.test("GET /users - filters by idRole", async () => {
  const filtered = users.filter((u) => u.idRole === 1);
  mockFetch({ [`${BASE}?idRole=1`]: filtered });
  try {
    const res = await fetch(`${BASE}?idRole=1`);
    assertEquals(res.status, 200);
    const data = await res.json();
    assertEquals(data.length, 1);
    assertEquals(data[0].idRole, 1);
  } finally {
    restoreFetch();
  }
 });
 // --- POST /users ---
 Deno.test("POST /users - creates a user and returns 201", async () => {
  const newUser = {
    id: "durand.claire",
    nom: "Durand",
    prenom: "Claire",
    idRole: 1,
  };
  mockFetch({ [BASE]: { method: "POST", status: 201, body: newUser } });
  try {
    const res = await fetch(BASE, {
      method: "POST",
      headers: { "content-type": "application/json" },
      body: JSON.stringify(newUser),
    });
    assertEquals(res.status, 201);
    const data = await res.json();
    assertEquals(data.id, "durand.claire");
    assertEquals(data.nom, "Durand");
  } finally {
    restoreFetch();
  }
 });
 Deno.test("POST /users - returns 409 on duplicate id", async () => {
  mockFetch({
    [BASE]: {
      method: "POST",
      status: 409,
      body: { error: "Un utilisateur avec cet identifiant existe déjà" },
    },
  });
  try {
    const res = await fetch(BASE, {
      method: "POST",
      headers: { "content-type": "application/json" },
      body: JSON.stringify(users[0]),
    });
    assertEquals(res.status, 409);
    const data = await res.json();
    assertEquals(typeof data.error, "string");
  } finally {
    restoreFetch();
  }
 });
 Deno.test("POST /users - returns 400 on missing fields", async () => {
  mockFetch({ [BASE]: { method: "POST", status: 400 } });
  try {
    const res = await fetch(BASE, {
      method: "POST",
      headers: { "content-type": "application/json" },
      body: JSON.stringify({ id: "x" }),
    });
    assertEquals(res.status, 400);
  } finally {
    restoreFetch();
  }
 });
 // --- GET /users/{id} ---
 Deno.test("GET /users/{id} - returns a user by id", async () => {
  mockFetch({ [`${BASE}/dupont.jean`]: users[0] });
  try {
    const res = await fetch(`${BASE}/dupont.jean`);
    assertEquals(res.status, 200);
    const data = await res.json();
    assertEquals(data.id, "dupont.jean");
    assertEquals(data.prenom, "Jean");
  } finally {
    restoreFetch();
  }
 });
 Deno.test("GET /users/{id} - returns 404 for unknown id", async () => {
  mockFetch({
    [`${BASE}/inconnu`]: {
      status: 404,
      body: { error: "Ressource introuvable" },
    },
  });
  try {
    const res = await fetch(`${BASE}/inconnu`);
    assertEquals(res.status, 404);
    const data = await res.json();
    assertEquals(typeof data.error, "string");
  } finally {
    restoreFetch();
  }
 });
 // --- PUT /users/{id} ---
 Deno.test("PUT /users/{id} - updates a user", async () => {
  const updated = { ...users[0], prenom: "Jean-Pierre" };
  mockFetch({
    [`${BASE}/dupont.jean`]: { method: "PUT", status: 200, body: updated },
  });
  try {
    const res = await fetch(`${BASE}/dupont.jean`, {
      method: "PUT",
      headers: { "content-type": "application/json" },
      body: JSON.stringify({ nom: "Dupont", prenom: "Jean-Pierre", idRole: 1 }),
    });
    assertEquals(res.status, 200);
    const data = await res.json();
    assertEquals(data.prenom, "Jean-Pierre");
  } finally {
    restoreFetch();
  }
 });
 Deno.test("PUT /users/{id} - returns 404 for unknown id", async () => {
  mockFetch({
    [`${BASE}/inconnu`]: {
      method: "PUT",
      status: 404,
      body: { error: "Ressource introuvable" },
    },
  });
  try {
    const res = await fetch(`${BASE}/inconnu`, {
      method: "PUT",
      headers: { "content-type": "application/json" },
      body: JSON.stringify({ nom: "X", prenom: "Y", idRole: 1 }),
    });
    assertEquals(res.status, 404);
  } finally {
    restoreFetch();
  }
 });
 // --- DELETE /users/{id} ---
 Deno.test("DELETE /users/{id} - deletes a user and returns 204", async () => {
  mockFetch({
    [`${BASE}/dupont.jean`]: { method: "DELETE", status: 204 },
  });
  try {
    const res = await fetch(`${BASE}/dupont.jean`, { method: "DELETE" });
    assertEquals(res.status, 204);
  } finally {
    restoreFetch();
  }
 });
 Deno.test("DELETE /users/{id} - returns 404 for unknown id", async () => {
  mockFetch({
    [`${BASE}/inconnu`]: {
      method: "DELETE",
      status: 404,
      body: { error: "Ressource introuvable" },
    },
  });
  try {
    const res = await fetch(`${BASE}/inconnu`, { method: "DELETE" });
    assertEquals(res.status, 404);
  } finally {
    restoreFetch();
  }
 });
 // --- getFetchCalls ---
 Deno.test("GET /users - call is tracked", async () => {
  mockFetch({ [BASE]: users });
  try {
    await fetch(BASE);
    const calls = getFetchCalls();
    assertEquals(calls.length, 1);
    assertEquals(calls[0].method, "GET");
  } finally {
    restoreFetch();
  }
 });
Author	SHA1	Message	Date
djalim	07b6f1e347	chore(test-framework): remove endpoint-specific tests from framework branch Tests / Unit tests (pull_request) Successful in 12s Details Tests / Integration tests (pull_request) Failing after 54s Details Each endpoint's tests will be on their own issue branch (PMPR-109, etc.). The framework branch only contains: CI config, db helpers, migrations. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-26 13:55:21 +02:00
djalim	c5018d9ced	test(integration): add DB integration tests for students, promotions, roles, modules Covers full CRUD for each resource via testDb: - promotions: list, create, get by id, not found, update, delete - students: list, filter by promo, create, get, not found, update, delete - roles: list, create, get with permissions, update+reset perms, delete - modules: list, create, duplicate id rejection, get, not found, update, delete 27 integration tests passing in CI (act + Gitea Actions). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-26 13:37:02 +02:00
djalim	367b0b2357	fix(ci): fix postgres TCP setup and truncateAll superuser error Tests / Unit tests (pull_request) Successful in 12s Details Tests / Integration tests (pull_request) Successful in 58s Details - Use apt-get install + configure listen_addresses + md5 auth in pg_hba so psql can connect via 127.0.0.1 (not just Unix socket) - Use pg_ctlcluster restart after config changes + wait for pg_isready - Replace session_replication_role (requires superuser) with a single TRUNCATE ... CASCADE which handles FK deps without elevated privileges - All 3 integration tests now pass in CI (act + Gitea Actions) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-04-26 13:22:45 +02:00
djalim	e0ac451372	fix(ci): use connection URL with ssl:false in drizzle config Tests / Unit tests (pull_request) Successful in 13s Details Tests / Integration tests (pull_request) Failing after 56s Details	2026-04-26 00:57:38 +02:00
djalim	ae5d5b64ac	debug(ci): add connection diagnostics before migrate Tests / Unit tests (pull_request) Successful in 11s Details Tests / Integration tests (pull_request) Failing after 56s Details	2026-04-26 00:54:11 +02:00
djalim	7be13737d5	fix(ci): remove unsupported --verbose from drizzle-kit migrate Tests / Unit tests (pull_request) Successful in 11s Details Tests / Integration tests (pull_request) Failing after 53s Details	2026-04-26 00:51:22 +02:00
djalim	32052ab1c9	fix(ci): add GRANT on public schema and verbose migrate output Tests / Unit tests (pull_request) Successful in 11s Details Tests / Integration tests (pull_request) Failing after 54s Details	2026-04-26 00:48:57 +02:00
djalim	ce807391c6	fix(ci): start postgres with pg_ctlcluster instead of systemctl Tests / Unit tests (pull_request) Successful in 11s Details Tests / Integration tests (pull_request) Failing after 53s Details	2026-04-26 00:46:02 +02:00
djalim	182342aab0	fix(ci): install postgres via apt-get instead of docker Tests / Unit tests (pull_request) Successful in 11s Details Tests / Integration tests (pull_request) Failing after 25s Details	2026-04-26 00:43:11 +02:00
djalim	d32758b310	fix(ci): use docker run instead of services for postgres	2026-04-26 00:41:20 +02:00
djalim	f26b2b044f	fix(ci): use bash /dev/tcp for postgres readiness check Tests / Unit tests (pull_request) Successful in 12s Details Tests / Integration tests (pull_request) Has been cancelled Details	2026-04-26 00:37:21 +02:00
djalim	af2562ef2b	fix(ci): replace pg_isready with nc for postgres readiness check Tests / Unit tests (pull_request) Successful in 11s Details Tests / Integration tests (pull_request) Has been cancelled Details	2026-04-26 00:35:42 +02:00
djalim	f739f94403	fix(ci): use deno install for unit tests, add postgres readiness check Tests / Unit tests (pull_request) Successful in 13s Details Tests / Integration tests (pull_request) Has been cancelled Details	2026-04-26 00:31:15 +02:00
djalim	f66de20dad	fix(ci): install npm deps before running unit tests Tests / Unit tests (pull_request) Failing after 27s Details Tests / Integration tests (pull_request) Failing after 27s Details	2026-04-26 00:27:07 +02:00
djalim	ea61d83384	fix(lint): add version to drizzle-orm imports and prefix unused NOT_FOUND Tests / Unit tests (pull_request) Failing after 6s Details Tests / Integration tests (pull_request) Failing after 1m28s Details	2026-04-26 00:24:27 +02:00
djalim	6402f802e9	chore(test): set up integration test framework with postgres - Generate Drizzle migrations (databases/migrations/) - Add databases/schema.kit.ts for drizzle-kit (Node-compatible imports) - Update drizzle.config.ts to use schema.kit.ts - Add deno tasks: test:unit, test:integration, migrate - Add tests/helpers/db_integration.ts: testDb, truncateAll, seed helpers - Add .gitea/workflows/test.yml: CI with postgres service container - Update lint.yml: run test:unit only (no DB needed) - Update deploy.yml: add check-code job, gate deploy on it	2026-04-26 00:23:12 +02:00