From 58c8ff56ba9e7a432470a68748997c64688432ff Mon Sep 17 00:00:00 2001
From: Djalim Simaila <DjalimS.pro@outlook.fr>
Date: Fri, 9 Jan 2026 12:41:51 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B(components):=20add=20missing=20but?=
 =?UTF-8?q?ton=20types=20and=20keys?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Add type="button" to the EditMobility and UploadStudents buttons
to prevent default form submission behavior.
Include a key prop on Student components in Promotion for stable list rendering.
---
 routes/(apps)/mobility/(_islands)/EditMobility.tsx   | 2 +-
 routes/(apps)/students/(_components)/Promotion.tsx   | 2 +-
 routes/(apps)/students/(_islands)/UploadStudents.tsx | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/routes/(apps)/mobility/(_islands)/EditMobility.tsx b/routes/(apps)/mobility/(_islands)/EditMobility.tsx
index ef3a485..8991926 100644
--- a/routes/(apps)/mobility/(_islands)/EditMobility.tsx
+++ b/routes/(apps)/mobility/(_islands)/EditMobility.tsx
@@ -240,7 +240,7 @@ export default function EditMobility() {
           </table>
         </div>
       ))}
-      <button onClick={handleSave} disabled={isSaving}>
+      <button type="button" onClick={handleSave} disabled={isSaving}>
         {isSaving ? "Saving..." : "Confirm"}
       </button>
     </section>
diff --git a/routes/(apps)/students/(_components)/Promotion.tsx b/routes/(apps)/students/(_components)/Promotion.tsx
index 985b637..8a6394f 100644
--- a/routes/(apps)/students/(_components)/Promotion.tsx
+++ b/routes/(apps)/students/(_components)/Promotion.tsx
@@ -22,7 +22,7 @@ export default function Promotion(props: PromotionProps) {
         <tbody>
           {props.students
             .filter((student) => student.promotionId === props.promo.id)
-            .map((student) => <Student student={student} />)}
+            .map((student) => <Student key={student.id} student={student} />)}
         </tbody>
       </table>
     </div>
diff --git a/routes/(apps)/students/(_islands)/UploadStudents.tsx b/routes/(apps)/students/(_islands)/UploadStudents.tsx
index 1ae11d7..6e21876 100644
--- a/routes/(apps)/students/(_islands)/UploadStudents.tsx
+++ b/routes/(apps)/students/(_islands)/UploadStudents.tsx
@@ -104,7 +104,7 @@ export default function UploadStudents() {
   return (
     <>
       <input type="file" accept=".xlsx, .xls" onChange={handleFileChange} />
-      <button onClick={confirmUpload}>Confirm Upload</button>
+      <button type="button" onClick={confirmUpload}>Confirm Upload</button>
       <p>{statusMessage.value}</p>
     </>
   );